Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #262 by separating new PROMPT_COMMAND commands #269

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #262 by separating new PROMPT_COMMAND commands #269

wants to merge 3 commits into from

Conversation

mrmanc
Copy link

@mrmanc mrmanc commented Aug 22, 2019

No description provided.

@mrmanc mrmanc mentioned this pull request Aug 22, 2019
Open
mrmanc added 2 commits August 22, 2019 17:07
@mrmanc
Prepend rather than append to PROMPT_COMMAND
296d37e 
This should avoid clobbering without needing to terminate other commands.
@mrmanc
Move quote to fix issue with bash expansion syntax
c2692dd
dmd
dmd suggested changes Oct 24, 2019
View reviewed changes
Copy link

@dmd dmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not as portable as z would like to be, because of the use of the double bracket construct.

dmd
dmd reviewed Oct 24, 2019
View reviewed changes
Copy link

@dmd dmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better.

dmd
dmd reviewed Oct 24, 2019
View reviewed changes
Copy link

@dmd dmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually see how this is significantly different from the existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmd dmd dmd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmanc @dmd